decentraland / snapshots-fetcher / 30489719569

96%

Build Type

push

github

Committed by web-flow

Commit Message

fix!: repair the unimportable package and stop sync advancing past undeployed entities (v3, Node 24) (#205)

* fix: declare fp-future and correct dependency placement

`src/synchronizer.ts` imports `fp-future`, but it was never declared as a
dependency. It resolved locally only because the `@dcl/http-server`
devDependency pulls it in, so a production install had nothing to satisfy
`require("fp-future")` from `dist/synchronizer.js` — which `dist/index.js`
re-exports. Every entry point of the published package therefore threw
MODULE_NOT_FOUND:

    $ npm ls fp-future --omit=dev
    @dcl/snapshots-fetcher@2.0.0
    └── (empty)

Verified by packing the tarball, installing it into a clean project with
--omit=dev and requiring it.

The mirror mistake is fixed too: `@dcl/fetch-component` was a production
dependency but is only used by `test/components.ts` (src takes
`IFetchComponent` from `@dcl/core-commons`), so it moves to devDependencies.

Also aligns the toolchain with the declared runtime: `@types/node` moves to
^22 to match `engines.node >= 22`, and TypeScript to ^5.7.

* chore: fix the build tooling, lint src/index.ts and document usage

- `make build` invoked `api-extractor`, which is neither declared nor
  installed, so the target always failed. It now runs `tsc` (matching
  `npm run build`) and a `make lint` target is added.
- `make clean` failed whenever `downloads/Qm*` matched nothing.
- jest's deprecated `globals: {'ts-jest': ...}` config moves to the
  `transform` form ts-jest 29 expects.
- `.eslintignore` no longer excludes `src/index.ts`. It was the only
  unlinted source file, and un-ignoring it immediately surfaced a
  `no-var-requires` violation and a formatting error — in the same file that
  held the unguarded metadata parsing fixed later in this series.
- The README's two TODOs ("verify hashes of downloaded files", "download to
  a temp folder then move") were both already implemented. Replaced with
  real usage docs, integrity notes an... (continued)

Coverage Stats

503 of 549 branches covered (91.62%)

Branch coverage included in aggregate %.

881 of 911 new or added lines in 13 files covered. (96.71%)

3 existing lines in 2 files now uncovered.

1484 of 1529 relevant lines covered (97.06%)

1580.88 hits per line