AfterShip / clickhouse-sql-parser / 30480769660

55%

master: 55%

Build Type

Pull #293

github

Committed by therealpandey

Commit Message

Keep GLOBAL an operator unless a join actually follows it

Ending the expression whenever GLOBAL was not followed by IN/NOT left the
keyword for the enclosing clause to pick up, and the select item parser
takes any non-reserved keyword as an implicit alias. So
`SELECT a GLOBAL FROM t` began parsing as `SELECT a AS GLOBAL FROM t`,
which ClickHouse rejects as a syntax error. Looking ahead for the join
operator instead narrows the back-off to the locality it was meant for and
leaves GLOBAL binding like IN everywhere else, as it did before.

The ARRAY JOIN guard compared against the uppercase keyword, but
parseJoinOp records each modifier's source spelling, so
`GLOBAL array JOIN arr` slipped past it and read the column list as a
table expression.

Pull Request Pull Request #293: Fix parsing of the GLOBAL/LOCAL join locality and GLOBAL NOT IN

Coverage Stats

43 of 47 new or added lines in 3 files covered. (91.49%)

514 existing lines in 3 files now uncovered.

9004 of 16502 relevant lines covered (54.56%)

3074.65 hits per line