gammerce / sklep-sms / 30479862516

82%

Build Type

push

github

Committed by web-flow

Commit Message

Fix two Sentry TypeError issues (#441)

* fix: validate tid parameter in PagePayment to prevent TypeError

Accessing /page/payment without a ?tid parameter caused a TypeError
because PurchaseDataService::restorePurchase() expects a string but
received null. Added an explicit null check that throws
EntityNotFoundException (404), consistent with the existing behavior
when the purchase data is not found.

* docs: add development and testing setup guide to README

Documents how to set up the local environment with Docker, install
dependencies using composer-v8.0.json, run the test suite, and
explains the dual composer config setup for PHP 8.0 vs 8.1+.

* fix: handle array values in captureRequest urldecode

PHP  can contain arrays when query parameters use array syntax
(e.g. platforms[]=sourcemod). Calling urldecode() on an array value
throws a TypeError. Now checks if the value is an array and maps
urldecode over each element instead.

* test: add e2e test for captureRequest with array query params

Recreates the exact failing request from Sentry: a GET to / with
platforms[]=sourcemod and other params. Goes through the production
code path (captureRequest() -> kernel) to verify no TypeError.

* test: cover captureRequest array query fix with unit and e2e tests

- FunctionsTest: directly tests captureRequest() with array  values
- ArrayQueryParamTest: e2e test using ->get() with the exact
  failing request params from Sentry

* docs: add production install command to README

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

12 existing lines in 2 files now uncovered.

11926 of 14498 relevant lines covered (82.26%)

36.35 hits per line