umputun / agterm / 30478003443
98%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 83
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.452%. Remained the same
30478003443

push

github

web-flow 
add New Window to the Dock menu (#319)

adds a **New Window** item to the application Dock menu, firing the same thing ⌥⌘N does. Asked for in discussion #313.

the Dock menu had New Session, Quick Terminal, Dashboard, recent sessions and sessions needing attention, but no way to open a window. Getting one still meant bringing agterm forward first and then ⌥⌘N, which is the one case the Dock menu exists for: acting on agterm without it being frontmost.

**why it is not a one-liner**

every other top-level Dock item captures the last-active window's store plus id and rechecks that window's modal state when chosen. A new window belongs to no existing window, so this one captures nothing and skips that gate.

two things in the existing code stood in the way:

- `AppActions.newWindow()` guards on `uiActionsEnabled`, which is the *frontmost* window's modal state (terminal zoom, an open dashboard, a pending picker). Wired straight through, the Dock item would go inert whenever the last-active window happened to be showing a dashboard. It now takes `ignoringModals`, defaulted false, so the menu bar and palette keep the gate and File ▸ New Window still reads as disabled while a modal is up. The bypass is the Dock's alone.
- ordinary window presentation does not activate the app. `WindowAccessor.bringForward` unhides and activates only on the UI-test path, so without an explicit `NSApp.unhide` + `NSApp.activate` the new window opens behind whatever app you right-clicked the Dock from.

**enabled state**

`actions != nil`, and nothing about the captured window. `actions` is wired in the scene `.task`, so during the launch window every other item is already disabled by the nil library, and an always-true New Window would be the only enabled item in the menu, one that brings the app forward and then does nothing.

that was the second commit. First cut had `enabled: true` and a review round caught it.

**also in here**

`newWindow` now creates only when the opener ... (continued)

6617 of 6790 relevant lines covered (97.45%)

4428008.15 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30478003443.1 83
97.45
 GitHub Action Run
Source Files on build 30478003443