AfterShip / clickhouse-sql-parser / 30478017550

55%

master: 58%

Build Type

Pull #293

github

Committed by therealpandey

Commit Message

Fix parsing of the GLOBAL/LOCAL join locality and GLOBAL NOT IN (#292)

GLOBAL and LOCAL were consumed as if they were join types, so any real
join type after them was rejected and the two forms that did parse lost
the keyword when formatting. Parse the locality as a prefix and continue
into parseJoinOp, keeping it in the join modifiers.

GLOBAL also claimed IN's precedence unconditionally, so a GLOBAL that
started the next join was read as an operator, and parseInfix demanded
IN immediately, leaving GLOBAL NOT IN with no path.

ARRAY JOIN takes no locality, and neither does LOCAL IN, matching
ClickHouse 26.8.1.337.

Pull Request Pull Request #293: Fix parsing of the GLOBAL/LOCAL join locality and GLOBAL NOT IN

Coverage Stats

67 of 73 new or added lines in 3 files covered. (91.78%)

543 existing lines in 3 files now uncovered.

8988 of 16489 relevant lines covered (54.51%)

3075.08 hits per line