AfterShip / clickhouse-sql-parser / 30469496639

55%

master: 55%

Build Type

Pull #290

github

Committed by therealpandey

Commit Message

Add traversal and position guards for the keyword argument forms

The keyword forms build UnaryExpr and BinaryOperation instead of a node of their
own, so nothing in walk.go or the position tests covered them. Assert that Walk
reaches every operand and that the spans match what the same nodes report
elsewhere, so a future change to either cannot regress them silently.

Also collapse the two comma checks, which returned the same error, into one.

Pull Request Pull Request #290: Support SQL-standard keyword arguments for trim, substring and overlay

Coverage Stats

110 of 128 new or added lines in 2 files covered. (85.94%)

539 existing lines in 2 files now uncovered.

9053 of 16586 relevant lines covered (54.58%)

3077.21 hits per line