dangernoodle-io / breadboard / 30468854247

97%

push

github

fix: defer bb_wifi GOT_IP NVS persist writes off sys_evt task (#1132)

bb_wifi.c's IP_EVENT_STA_GOT_IP handler ran bb_settings_wifi_pending_promote/
_provisioned_mark_connected/bb_system_boot_count_reset synchronously on the
ESP-IDF default event-loop task ("sys_evt"), whose stack was measured at 140
of 2304 bytes free (94% used) with these NVS writes on its deepest call
chain -- vs 1340 B free in portal mode, where GOT_IP never fires.

- pure bb_wifi_got_ip_persist_decide() (host-tested, 100% line+branch) maps
  (pending_try, boot_count_already_cleared) to which of the three writes to
  perform
- the actual writes now run on the shared bb_timer_disp task via a
  file-static one-shot timer, re-armed (never re-created) per GOT_IP,
  mirroring floor_app.c's HW-CONFIRMED prov_reboot_work_fn precedent
- concurrent GOT_IPs merge (OR) their decision flags rather than
  overwriting, so a fast reconnect can never drop a still-pending write;
  timer-create failure falls back to applying inline rather than dropping
- boot_count_reset is now latched at most once per boot instead of on every
  GOT_IP (including every reconnect)
- update bb_settings.h's provisioned-transition seam doc: the observer now
  fires on bb_timer_disp, not the WiFi/IP event task

HW-validated: sys_evt free stack went from 140/2304 (94% used) to
~964-1020 B free. bb_timer_disp worst case measured at 2384/4096 used
(1712 B free), including the deepest path where the provisioned-flag
write and its transition notify both re-ran on the same timer callback.


Claude-Session: https://claude.ai/code/session_01KM3KoyubaoM6eoUAsw8GYr

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7920 of 8524 branches covered (92.91%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

13482 of 13637 relevant lines covered (98.86%)

2608.95 hits per line