AfterShip / clickhouse-sql-parser / 30468832682

55%

master: 55%

Build Type

Pull #290

github

Committed by therealpandey

Commit Message

Keep argument aliases and parametric lists on the keyword path

The keyword-argument parser parsed each argument with parseExpr, losing three
things parseColumnExprListWithLParen does on the path it replaces. Because every
call to these four functions is routed through it, plain comma calls lost them
too:

- an optional `AS <alias>` per argument, so `trim('x' AS y)` and
  `substring('h' AS s, 2)` stopped parsing although ClickHouse accepts them
- a leading DISTINCT
- a trailing parametric argument list

Also drop the fixture and assertion for `trim(both)` and `trim(both, x)`:
ClickHouse rejects both, because its trim grammar always reads BOTH as the
modifier, so they were the wrong thing to pin. BOTH as an ordinary name is still
covered through max(both) and an alias.

Reuse parseOneStmt from position_test.go rather than a second copy of it.

Pull Request Pull Request #290: Support SQL-standard keyword arguments for trim, substring and overlay

Coverage Stats

111 of 129 new or added lines in 2 files covered. (86.05%)

550 existing lines in 2 files now uncovered.

9042 of 16587 relevant lines covered (54.51%)

3075.48 hits per line