supabase / supabase-swift / 30459456649

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(realtime): resume WebSocket continuations outside the lock (#1156)

Same anti-pattern as the AsyncValueSubject deadlock
(supabase/supabase-swift#1154): `onComplete`, `onWebSocketTaskOpened`,
and `_trigger` resumed/yielded continuations while holding
`mutableState`'s lock. Resuming a continuation can synchronously reach
into the Swift runtime's task status-record lock, which risks a
lock-order inversion if cancellation ever calls back into this lock
(not currently wired up, but the pattern is fragile and one
`withTaskCancellationHandler`/`onTermination` away from reintroducing
the same class of deadlock).

Compute the action under the lock, run it (resume/yield) after
releasing it — mirrors the fix already applied to AsyncValueSubject.

Coverage Stats

25 of 38 new or added lines in 1 file covered. (65.79%)

1 existing line in 1 file now uncovered.

8439 of 10042 relevant lines covered (84.04%)

39.54 hits per line