cheeriojs / cheerio / 30460032950

100%

main: 100%

Pull #5381

github

refactor: address the actionable @feedic/eslint-config 0.5 reports

Everything the new rules found that was worth acting on.

src:
- `attr()`, `prop()` and `readAllData()` iterate `Object.entries()` instead
  of `Object.keys()` plus a lookup.
- `prop()` matches `href`/`src` tag names against two module-level sets
  rather than a chain of seven equality checks.
- `val()` builds the `option:selected` selection after the setter branch
  returns, instead of on every call.
- `addClass()` uses an early return.
- `Cheerio.prevObject` is declared with the other fields rather than after
  the constructor, and picks up a doc comment.
- `merge()` drops `+arr2.length`: `isArrayLike()` has already established
  that `length` is a number.

website and scripts: early returns in the rehype and remark plugins, a
direct index assignment in place of a one-element `splice()`, the RSS
`context.site` guard hoisted above the sort, and the blog schema's nested
`z` calls lifted into named values.

Two reports are suppressed inline as false positives, both verified:

- `eq()` keeps `i = +i`. Without it `eq('-1')` reaches `this.length + i` as
  string concatenation and returns an empty selection instead of the last
  element.
- `isArrayLike()` keeps `item.length < 0`. The rule assumes an array; `item`
  is an arbitrary object under validation, so `length` really can be negative.

`forms.spec.ts` sorts with `localeCompare` instead of a comparator that
never returned 0.

265 of 265 branches covered (100.0%)

Branch coverage included in aggregate %.

873 of 878 relevant lines covered (99.43%)

378.18 hits per line