source-academy / frontend / 30454968033

44%

Build Type

push

github

Committed by web-flow

Commit Message

feat: Integrate autocomplete <-> frontend (#4190)

* feat: load autocomplete modes through runner plugin

* fix: preserve disabled Conductor flag

* fix: fix lookup for non-autocomplete evaluators

* fix: resolve dependency paths and lookupPlugin crash on cleanup

package.json's @sourceacademy/common-autocomplete, web-autocomplete, and
runner-module-loader were pointing at file:..\plugins\src\... - a
Windows-style local sibling-checkout path from the author's machine that
doesn't exist in CI or for any other contributor. Swapped for the
published npm ranges (web-autocomplete needs ^0.0.2 specifically -
0.0.1 shipped with an unresolvable workspace:* internal dependency).

.yarnrc.yml's npmPreapprovedPackages needed the three new first-party
packages added, since npmMinimalAgeGate otherwise quarantines any
package version under 3 days old.

terminatePreparedConductor assumed conduit.lookupPlugin() returns null
when a plugin was never registered, but it actually throws
ConductorInternalError. Any conductor cleanup where the runner hadn't
yet requested the autocomplete plugin (e.g. switching evaluators before
first use) threw uncaught, aborting the saga that prepares the next
conductor - so neither syntax highlighting nor autocomplete ever
activated for any Conductor-backed language. Wrapped in try/catch.

* fix: bind Ace mode hooks to their source instance, guard stale mode publishes

AutocompletePlugin.loadSynchronousModeMethod extracted checkOutdent/
autoOutdent/getNextLineIndent from a freshly-constructed Ace mode
instance but returned the bare function. Modes that delegate to
internal state (e.g. matching_brace_outdent's this.$outdent - used by
several bundled modes) lose that receiver once the function is
assigned onto our own Mode.prototype, and throw when Ace invokes the
hook. Bind each extracted method to the instance it came from.

Removed a dead `if (this.currentMode)` check in the constructor -
currentMode is a field initialized to null and no... (continued)

Coverage Stats

2860 of 7662 branches covered (37.33%)

Branch coverage included in aggregate %.

53 of 95 new or added lines in 7 files covered. (55.79%)

1 existing line in 1 file now uncovered.

6627 of 14384 relevant lines covered (46.07%)

28.56 hits per line