cheeriojs / cheerio / 30449268863

100%

main: 100%

Pull #5379

github

fix(static): let $.html() keep the instance parser mode

`html()` built its options as `{ ...this._options, ...flattenOptions(options) }`.
`flattenOptions(undefined)` returns the module-level defaults, which carry
`_useHtmlParser2: false`, so the spread overwrote the instance's parser
flag and an htmlparser2-backed instance serialized through parse5. Raw
text was entity-escaped and void elements gained closing tags:

  load('<style>a < b && c > d</style><p>x<br>y</p>', { xmlMode: true })
  $.html(undefined, { xmlMode: false })
  // was: <style>a &lt; b &amp;&amp; c &gt; d</style><p>x<br>y</br></p>

Pass the instance options as the base instead, which is what
`flattenOptions` takes its second argument for. `flattenOptions(undefined,
undefined)` still returns the defaults, so `html.call(null)` is unchanged.

262 of 262 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

865 of 870 relevant lines covered (99.43%)

314.7 hits per line