PHP-Alchemist / coreFiles / 30448055679

97%

master: 93%

push

github

Fix code-review follow-ups on release/v3

- AbstractIndexedArray::merge() now unwraps an IndexedArrayInterface to
  its underlying array before array_merge(), fixing a TypeError on the
  object path the signature already advertised.
- Remove dead/broken `use PHPAlchemist\Type\Base\Default;` import.
- AbstractString null-safety: guard contains(), startsWith(), endsWith(),
  indexOf(), lastIndexOf(), and length() against a null value so they no
  longer emit deprecations on an empty Twine.
- AccessorTrait::is() throws VariableNotFoundException for unknown fields,
  consistent with get()/set().
- Remove PHPAlchemist\Trait\PerformanceTrait and its test, aligning the
  code with the 3.0.0 CHANGELOG "Removed" entry.
- Add tests: merge() with an IndexedArrayInterface object, is() on an
  unknown field, and null-valued Twine queries.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

11 of 11 new or added lines in 3 files covered. (100.0%)

475 of 492 relevant lines covered (96.54%)

5.6 hits per line