unioslo / mreg / 30444077253

98%

push

github

Fix stale pull request CI compatibility (#641)

## Summary

- Preserve the pre-#628 field order for `NetworkSerializer` and `NetGroupRegexPermissionSerializer`.
- Retain the explicit `network` and `range` fields required for OpenAPI generation.
- Restore `mreg.api.views.LIBRARIES_TO_REPORT` as a compatibility alias.
- Ensure mreg-cli tests the image built for the current pull request.
- Add regression tests for both serializer orders and the compatibility alias.

## Root cause

### Serializer field ordering

PR #628 explicitly declared two custom model fields so drf-spectacular could describe them:

```python
NetworkSerializer.network = serializers.CharField()
NetGroupRegexPermissionSerializer.range = serializers.CharField()
```

Combined with `fields = "__all__"`, DRF moved those fields earlier in the serialized output.

`NetworkSerializer` changed from:

```text
id, excluded_ranges, policy, communities, created_at, updated_at, network, ...
```

to:

```text
id, network, excluded_ranges, policy, communities, created_at, updated_at, ...
```

`NetGroupRegexPermissionSerializer` changed from:

```text
id, created_at, updated_at, group, range, regex, labels
```

to:

```text
id, range, created_at, updated_at, group, regex, labels
```

Although JSON object order is not semantically significant, mreg-cli’s recorded-output tests compare it, and stable serialization avoids unnecessary changes for existing consumers.

Both serializers now use explicit field tuples in their previous order while retaining the explicit custom fields required for OpenAPI generation.

### Renamed constant

PR #628 moved the reported-library constant from `mreg.api.views` to `mreg.api.serializers` and renamed it to `REPORTED_LIBRARY_VERSION_FIELDS`.

In-flight pull requests created before #628, including #616, still import `LIBRARIES_TO_REPORT` from `mreg.api.views`. The previous name is retained as an alias:

```python
LIBRARIES_TO_REPORT = REPORTED_LIBRARY_VERSION_FIELDS
```

Thi... (continued)

10 of 10 new or added lines in 3 files covered. (100.0%)

10310 of 10553 relevant lines covered (97.7%)

4.88 hits per line