source-academy / py-slang / 30423622243

86%

push

github

Fix draw_data's minimum argument count: 1, not 2 (#367)

Both engines' draw_data validated a minimum of 2 arguments, citing
"python_2_specs.md's own documented signature" as the source — but no
such file exists anywhere in the org (checked via GitHub code search).
The actual tracked spec source, docs/lib/linked_list.py, was long ago
written as `def draw_data(value1, *values)` (added in #89, years before
draw_data was implemented) - one required argument, matching js-slang's
own minimum. The generated docs page rendering as `draw_data(value1,)`
(which looked like it supported this) was actually a symptom of the
same underlying mismatch: the def line said 2 required args while the
docstring's Parameters section, copied from llist's variadic-only
template, only ever named one.

- src/stdlib/dataVisualizer.ts (CSE): @Validate(2, ...) -> @Validate(1, ...)
- src/engines/py2js/stdlibBridge.ts: nativeDrawData's arity check and
  pyMinArgs, 2 -> 1
- docs/lib/linked_list.py: def draw_data(value1, value2, *values) ->
  def draw_data(value1, *values), with a Parameters block that
  documents value1 and *values separately instead of merging them
- Updated existing arity tests (dataVisualizer.test.ts,
  Py2JsEvaluator.test.ts) so draw_data(1) is now a valid call, and
  added a single-argument case to py2js-draw-data.test.ts


Claude-Session: https://claude.ai/code/session_014SWoqgBNWe8oP21aL2qejk

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

4443 of 5546 branches covered (80.11%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

9630 of 10779 relevant lines covered (89.34%)

179280.52 hits per line