dangernoodle-io / breadboard / 30420865498

97%

push

github

fix: ratchet uncovered branches per-file locally, lines-only in CI (#1129)

the local coverage gate only baselined uncovered_line markers, so a
branch-only regression (100% new-code line coverage, an uncovered new
branch) false-passed locally while Coveralls correctly failed it
(PR #1120). uncovered_branch markers are now baselined the same way as
lines, keyed by source line number only (never a gcov branch-edge id,
which PR #850 found unstable across gcc majors) -- a marker means "this
line has an uncovered branch", not "branch N of this line is uncovered",
so it's insensitive to how a given gcc major splits a conditional.

the committed baseline is extended additively: coverage_baseline.seed()
is now per-marker-TYPE, so the existing uncovered_line entries were left
untouched and the day-one uncovered_branch gap (501 markers, matching the
92.9% aggregate branch coverage) was seeded once as a reviewed baseline
edit, never silently blessed by --update-baseline (still shrink-only).

CI/local split (PR #1127 CI failure): the line-keying narrowed but did
not eliminate cross-gcc-major branch instability -- CI failed with two
uncovered_branch markers that never reproduced locally, because CI's gcc
major legitimately disagrees with the seeding machine's on whether some
lines have an uncovered branch at all, not just on the edge count. Per
user decision, uncovered_branch ratcheting is now a LOCAL PRE-PUSH AID
ONLY: `COVERAGE_GATE_LINES_ONLY`, set explicitly by
.github/workflows/build.yml's pre-build-script (never auto-detected from
a generic CI env var), drops uncovered_branch markers from the gate
entirely in CI -- uncovered_line ratcheting is completely unaffected and
still gates CI exactly as before. Coveralls remains the sole CI authority
for branch coverage. check() also gained an ignore_types parameter so the
501 branch baseline entries don't spam CI logs as false "candidate to
prune" noise once current no longer contains any uncovered_branch marker.

v... (continued)

7896 of 8500 branches covered (92.89%)

Branch coverage included in aggregate %.

13427 of 13582 relevant lines covered (98.86%)

2616.14 hits per line