valkyrjaio / project-template-java / 30419578047
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30419578047

push

github

web-flow 
[CI] Align the test tree and bring it under Spotless, ErrorProne, SpotBugs, and ArchUnit (#27)

# Description

Brings the project template in line with the test-root rule codified in
valkyrjaio/architecture#79,
and closes the static-analysis gap that left its test tree unchecked by
every tool.

This repo matters more than its size suggests: it is the **scaffolding
source of truth** for Java
(canonical rule §3.9), so every new Java repo is generated from it. Left
as-is, it seeds both defects
into everything created from it. Fixing it here is what stops the drift
recurring — the sibling
repos (valkyrjaio/valkyrja-java#63 and #66, valkyrjaio/sindri-java#60,
valkyrjaio/valkyrja-starter-app-java#56) were each cleaning up a copy of
what this repo hands out.

**The test tree had no test root.** Its one test sat at
`io.valkyrja.unit.template.constant`, a
sibling of the framework's own namespaces. It now sits at
`io.valkyrja.tests.unit.template.constant`,
matching PHP `Valkyrja\Tests\`, TypeScript `tests/Tests/`, and the three
sibling Java repos.

**No tool saw the tests.** Error Prone, SpotBugs, and ArchUnit all
pointed only at `src/main/java`,
their own test source sets were empty, and Spotless targeted
`src/**/*.java` alone. Every job's
`files:` filter had the matching hole, so a test-only change skipped all
four. Java has no
type-checking gap — `javac` compiles the tests as a precondition of
running them — so this is purely
static analysis. Nothing was found to fix: the existing test is already
clean under all four tools.

The configuration is deliberately identical to the sibling repos, so a
repo scaffolded from here
starts with the same gate the framework has, and the shipped
`TestArchitectureTest` and
`spotbugs-exclude-test.xml` give it working defaults to extend rather
than an empty file to invent.

Three details carried over from the sibling repos, each of which cost
real debugging there:

- **Spotless targets `src/test/java`, not `src/test/**`.** The... (continued)

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30419578047.1 1
100.0
 GitHub Action Run
Source Files on build 30419578047