valkyrjaio / valkyrja-java / 30417884481

100%

push

github

[Http] Build a dynamic route from a route whose path declares a parameter (#67)

# Description

A route declared with a `{parameter}` in its path but with the plain
`@Route` annotation was
never turned into a dynamic route, so the processor built no regex for
it and the route could
never match. Only `@DynamicRoute` produced a working route.

PHP resolves this in `RouteFactory::fromRoute()`: a path containing `{`
describes a dynamic
route, so one is built (keeping any parameters the route already
carries); every other path
yields a static route. The Java port had no such factory —
`AttributeRouteCollector` built a
plain `io.valkyrja.http.routing.data.Route` and handed it straight to
the processor, which
only builds a regex for a `DynamicRouteContract`.

This port adds the missing factory and uses it, so the two annotations
agree: whichever one
declares the placeholder, the collector produces a dynamic route and
attaches the
`@Parameter`s the method declares.

Found while adding one route per routing permutation to the example
application
(valkyrjaio/valkyrja-starter-app-java), where every dynamic route
declared this way matched
when generated into the cache but not when collected at runtime.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`http/routing/factory/RouteFactory.java`** — new factory mirroring
PHP's: `fromRoute()` returns a `DynamicRoute` when the path carries a
`{parameter}` (preserving the parameters of a route that is already
dynamic) and a `Route` otherwise, plus the request/response struct
helpers.
- **`http/routing/collector/AttributeRouteCollector.java`** — a route
collecte... (continued)

1924 of 1926 branches covered (99.9%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 2 files covered. (100.0%)

7005 of 7005 relevant lines covered (100.0%)

4.33 hits per line