valkyrjaio / sindri-php / 30416052543
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30416052543

push

github

web-flow 
[Generator] Refresh the golden snapshots via a GOLDEN_UPDATE environment switch (#178)

# Description

Refreshing a golden snapshot after an intentional generator change is
the one
part of this suite that is not self-service: the class docs tell you to
regenerate each `golden/*.golden` from the matching input by hand. The
docblock
justified leaving it that way — "the assertion here is intentionally a
pure
`assertSame` with no update-mode branch, so coverage stays complete" —
but that
reasoning does not hold. `.github/ci/phpunit/phpunit.xml.dist` scopes
`<source>`
to `../../../src`, so a branch inside a test file is never measured and
cannot
affect coverage either way.

Both sibling ports already have the switch — TypeScript from the start,
Java as
of valkyrjaio/sindri-java#57 — which left PHP, the reference
implementation, as
the only one without it. This closes that gap and corrects the
docblock's
rationale.

Verified by corrupting `AppEventData.golden`: the suite fails on it
normally, and
a `GOLDEN_UPDATE=1` run rewrites it byte-identical to the generator
output and
passes. Full gate green — PHPStan, Psalm, PHP CodeSniffer, PHP-CS-Fixer,
Rector,
PHPArkitect, and PHPUnit at 100% line and branch coverage.

Sibling PR: valkyrjaio/sindri-java#57 (already merged).

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`GoldenSnapshotTest.php`** — `assertGolden` rewrites the committed
golden
from the generated source when `GOLDEN_UPDATE=1` is set before
comparing;
the class docblock now describes that workflow and records why the
update
branch cannot affect coverage, replacing the incorrect claim it
displaces.

1554 of 1554 relevant lines covered (100.0%)

17.53 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30416052543.1 79
100.0
 GitHub Action Run
Source Files on build 30416052543