valkyrjaio / valkyrja-php / 30415598297

100%

push

github

[Cli] Remove the unreachable empty allowed responses clause from Answer::isValidResponse (#945)

# Description

`Answer::isValidResponse()` opened with a clause that can never evaluate
to `true`:

```php
return ($this->allowedResponses === [] && $validationCallable === null)
    || in_array($userResponse, $this->allowedResponses, true)
    || ($validationCallable !== null && $validationCallable($userResponse));
```

`$this->allowedResponses` is never empty. The constructor appends
`$defaultResponse` when it is
absent, and `withAllowedResponses()` does the same, so
`$this->allowedResponses === []` is always
`false` and the `$validationCallable === null` half is never even
evaluated. This was the one
branch in `Answer.php` that no test could reach (30/31 branches), found
while closing branch
coverage gaps.

Both halves of that dead clause arrived in the same commit
(`2c2583007`): _"Updating Answer to add
the default response to allowed responses, **and** fix validation if no
allowed responses or
validation callback were set."_ Before it, `isValidResponse()` was
`in_array(...) || callable(...)`,
so an `Answer` with neither an allowed list nor a callable could never
validate — and
`QuestionWriter::askQuestion()` re-asks until the response is valid, so
it looped forever. That one
bug was fixed two independent ways at once, and appending the default
response fully resolves it on
its own. The fallback clause has been redundant ever since.

The empty-allowed-responses case was therefore never meant to mean
"accept anything" — it meant
"such an `Answer` must be answerable." Accepting anything would also
contradict `QuestionWriter`,
which prints the allowed responses to the user as their valid choices.
The resulting semantics —
an `Answer` given neither an allowed-response list nor a validation
callable accepts only the
default response — is already asserted by the existing
`testValidationCallback()` and passes on
`26.x` today, so removing the clause is a no-op... (continued)

1 of 0 new or added lines in 0 files covered. (NaN%)

12593 of 12593 relevant lines covered (100.0%)

23.76 hits per line