collective / icalendar / 30411639317

98%

push

github

Fix: ATTACH is not an Alarm singleton (#1606)

* Fix: ATTACH is not an Alarm singleton

ATTACH was listed in both Alarm.singletons and Alarm.multiple. Per
RFC 5545 section 3.6.6, an "email" VALARM MAY include more than one
ATTACH, so ATTACH belongs in `multiple` only. Removed it from
`singletons` and added a regression test asserting `singletons` and
`multiple` are disjoint for every registered component.

Relates to #1569.

AI disclosure (per icalendar's AI policy): this change was prepared
with the assistance of Anthropic's Claude Opus 4.8, used as a coding
agent. It audited the singletons/multiple class variables across the
component classes, identified the ATTACH contradiction, wrote the fix
and the disjointness test, and ran the affected test suite locally to
confirm no regressions. The author reviewed and takes responsibility
for the change.

* Address review feedback on PR #1606

- Drop the now-redundant comment in Alarm.singletons (per @stevepiercy)
- Point the changelog RFC reference at the section anchor (:rfc:`5545#section-3.6.6`)
- Reformat the regression test so ruff format leaves it unchanged, fixing
  the failing "detect changes on the file system" CI step

Prepared with the assistance of an AI coding agent (Anthropic's Claude Opus 4.8).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>

843 of 865 branches covered (97.46%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

13746 of 14022 relevant lines covered (98.03%)

6.86 hits per line