medplum / medplum / 30394181542

92%

main: 92%

push

github

[Server] Remove Slot.serviceType from $find/$book results (#9998)

In https://github.com/medplum/medplum/pull/9995 it was flagged that
`Slot.serviceType` has some intended semantics for our availability
computations that we are not currently respecting; a "busy" slot with a
`serviceType` set should only block availability for matching services.

One challenge in merging that: the intent of `$find`/`$book` is that the
Slots created should remove the scheduled time from availability for all
service types. That means that these slots should be "wildcard", or
applicable to all service types.

In early implementation we had started including `Slot.serviceType` on
these results, which is in conflict with this intention.

As an immediate step, let's stop writing `Slot.serviceType` for new
$find/$book results. We will follow up with a migration plan for
existing Slot resources in this bad state.

Signed-off-by: Noah Silas <noah@medplum.com>

22650 of 25733 branches covered (88.02%)

Branch coverage included in aggregate %.

40205 of 42602 relevant lines covered (94.37%)

12284.32 hits per line