romshark / jscan / 30394507426

98%

main: 99%

Build Type

Pull #27

github

Committed by romshark

Commit Message

fix: Missed overflow in I8, I16 and I32

The signed parsers inferred overflow from the sign of the result, which
only holds if the value wraps once. The longest accepted digit strings
can wrap several times and land back in the correct sign, so Token.Int8
returned (44, nil) for the JSON value 300 instead of ErrOverflow.

The cases that can overflow now compute in the next wider type and
bound-check before narrowing. U8, U16, U32, U64 and I64 were unaffected.

test: Add FuzzAtoi, exhaustive 8/16-bit and boundary tests against
strconv, and regression rows for the affected ranges.

Pull Request Pull Request #27: Tokenizer API

Coverage Stats

718 of 731 new or added lines in 1 file covered. (98.22%)

4 existing lines in 1 file now uncovered.

1841 of 1873 relevant lines covered (98.29%)

33533.6 hits per line