stacklok / toolhive / 30385920289

70%

Build Type

push

github

Committed by web-flow

Commit Message

Remove referencingWorkloads/referenceCount from config CRD statuses (#5631)

* Stop storing referencing workloads on config CRD statuses

Remove the ReferencingWorkloads and ReferenceCount status fields from the six
config CRDs (MCPOIDCConfig, MCPAuthzConfig, MCPExternalAuthConfig,
MCPTelemetryConfig, MCPWebhookConfig, MCPToolConfig) and the machinery that
maintained them. After the indexer + stale-scan-removal work, that denormalized
list was kept fresh only to power a kubectl printer column — it no longer backs
deletion protection, which the finalizer recomputes live via
findReferencingWorkloads.

- Drop both fields (and the "References" printcolumn markers) from the v1beta1
  status structs and the v1alpha1 type markers; regenerate deepcopy.
- Remove the status-population paths in Reconcile, the workload watches and their
  map handlers (which existed only to refresh the list), and the
  workloadReferenceCount helper. Keep findReferencingWorkloads + the field
  indexes for the on-demand deletion check, and the DeletionBlocked condition.
- Update unit tests and the stale comments in the workload controllers.

BREAKING CHANGE: status.referencingWorkloads and status.referenceCount are
removed from all six config CRDs. Anything reading those fields (automation,
scripts, the kubectl "References" column) will no longer find them. Deletion
protection is unchanged.

See #5607.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Update config integration suites for removed status fields

Drop the envtest specs that asserted Status.ReferencingWorkloads /
ReferenceCount tracking and pruning (those fields are gone). Deletion-protection
coverage is retained, rewritten to assert via the DeletionBlocked condition and
object existence rather than the removed list.

See #5607.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Regenerate config CRD manifests and API docs

Regenerate the six config CRDs and crd-api.md after... (continued)

Coverage Stats

6 of 7 new or added lines in 4 files covered. (85.71%)

34 existing lines in 8 files now uncovered.

82191 of 117510 relevant lines covered (69.94%)

97.75 hits per line