valkyrjaio / valkyrja-starter-app-php / 30375420979

100%

push

github

[Http] Add the missing method not allowed error view (#172)

# Description

A request whose path matches a route but whose method does not — for
example `GET` on a
route declared `requestMethods: [RequestMethod::POST]` — crashed with an
uncaught
`ViewInvalidPathException` instead of rendering a Method Not Allowed
page.

The framework correctly resolves such a request to a `405`, and
`ViewRouteNotMatchedMiddleware` then renders the `errors/<status code>`
template. The
application ships `errors/404` for each of its three renderers but never
shipped an
`errors/405`, so the render threw and the response never completed.

Found while adding a method-restricted route to the application's
routing permutations; the
first `GET` against a `POST`-only route surfaced it.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/resources/views/errors/405.phtml`** — added the Method Not
Allowed view for the default PHP renderer, mirroring `404.phtml`.
- **`app/resources/views/errors/405.orka.phtml`** — added the Orka
variant, mirroring `404.orka.phtml`.
- **`app/resources/views/errors/405.twig`** — added the Twig variant,
mirroring `404.twig`.

91 of 91 new or added lines in 3 files covered. (100.0%)

420 of 420 relevant lines covered (100.0%)

1.78 hits per line