geosolutions-it / MapStore2 / 30357964400

76%

Build Type

push

github

Committed by web-flow

Commit Message

Fix #12689 - Remove unnecessary src=null on WMS tile load error (#12691)

* Fix #12689 - Remove unnecessary src=null on WMS tile load error

Setting img.src = null does not clear the image; the DOM coerces it
to the string "null", causing a real (always-404) network request.
image.setState(3) alone already triggers the source's
tileloaderror/imageloaderror events (state-based, no DOM event
dependency), making the src=null line redundant.

* Add test for #12689 spurious /null request removal

Verifies the tile error handler no longer sets img.src = null on failure.

* Fix #12689 - set error state on single tile WMS load failure

ol/Image has no setState, unlike ol/ImageTile: notify the state change
manually so imageloaderror is emitted without setting img.src to null.
Tests now configure requestsConfigurationRules to reach the custom load
function error branch.

Coverage Stats

35989 of 56678 branches covered (63.5%)

7 of 9 new or added lines in 1 file covered. (77.78%)

2 existing lines in 1 file now uncovered.

44763 of 59077 relevant lines covered (75.77%)

124.32 hits per line