Qiskit / qiskit / 30355781039

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Make the parser error channel and custom-classical callables pyo3-free (#16571)

* New error type

* New type for expressino step

* Add custom calable fn type

* Fix rebase conflicts

* Use the call

* Fix the tests

* Clippy and fmt

* Impl From trait for ParseError and use Box instead of Arc for source

* Fmt after rebase

* Use Cargo.lock from main

* Simplify error handling

When we're bubbling up a Python-space exception as part of `PyErr`, we
don't need to reproduce its message, because it already will be
displayed/inspectable.  In cases where we don't have any meaningful
additional context to add, we could either refactor `ParseError` to be
an `enum` with an explicit raw `Py` variant, or we can (as this commit
does) simply say we've caught an exception and chained it on.

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Coverage Stats

232 of 244 new or added lines in 7 files covered. (95.08%)

24 existing lines in 3 files now uncovered.

113258 of 129325 relevant lines covered (87.58%)

997033.59 hits per line