vocdoni / saas-backend / 30350727059

63%

main: 62%

Pull #608

github

refactor(members): centralize member normalization in Normalized()

Addresses review feedback on the whitespace hotfix.

The trimming was duplicated: prepareOrgMember normalized fields for
storage and authFirstStep repeated the same rules for the login request.
That duplication is the bug class this hotfix exists to fix, so it invites
the same drift again. OrgMember.Normalized() is now the single definition
of the canonical form and both sides call it, which makes disagreement
between how a field is stored and how it is compared impossible by
construction.

normalizeBirthDateInput moves out of the CSP handler package to
internal.NormalizeBirthDate, alongside the ParseBirthDate it wraps, with
its test. Normalized() deliberately does not validate: at login an
unparseable value should simply fail to match a participant, while at
write time prepareOrgMember still validates and reports what it rejects.

Also from review:

- trimmembers logged the full MongoDB URI, credentials included. It is run
  by hand against production, so that output reaches terminal scrollback
  and CI logs. It now logs the hosts only.
- The backfill doc claimed each member was "all-or-nothing", implying a
  transaction that does not exist (multi-document transactions need a
  replica set, which is not assumed). It now states the real guarantee:
  no write until the collision checks pass, participants before the
  member. That order makes a partial failure recoverable by re-running,
  because the member still matches the whitespace prefilter.
- Reworded a non-idiomatic comment about the unindexed regex prefilter.

165 of 316 new or added lines in 6 files covered. (52.22%)

10526 of 16770 relevant lines covered (62.77%)

45.89 hits per line