source-academy / plugins / 30350942821

97%

feat/add-init-infra: 67%

push

github

Fix stale packageManager pin blocking npm publish for new packages (#73)

Every workspace package's own package.json still pinned
"packageManager": "yarn@4.6.0", left over from before root's pin was
bumped to yarn@4.12.0. npm publish's prepack script runs `yarn build`
with cwd = that package's own directory, so Corepack resolved the
package's stale 4.6.0 pin instead of root's 4.12.0 - and yarn 4.6.0
doesn't recognize the npmPreapprovedPackages key now in .yarnrc.yml,
so it hard-failed before ever building anything:

  Usage Error: Unrecognized or legacy configuration settings found:
  npmPreapprovedPackages

This was latent for a long time because changeset publish only runs
a package's prepack when it needs a *fresh* publish - every
already-published package skips it. PR #71 (data visualizer) was the
first to add brand-new packages since root's pin was bumped, so it's
the first to trip this: common-data-visualizer, runner-data-visualizer,
and web-data-visualizer all failed to publish, which also aborted the
GitHub Pages deploy job since it needs the build job to succeed.

Verified locally: `npm publish --dry-run` now succeeds for all three
data-visualizer packages.

46 of 50 branches covered (92.0%)

Branch coverage included in aggregate %.

129 of 129 relevant lines covered (100.0%)

10.06 hits per line