hyperledger / fabric-x-committer / 30346792200

91%

Build Type

push

github

Committed by web-flow

Commit Message

[loadgen] Consolidate workload config; batch build/sign generation pipeline (#699)

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

Two behavior-preserving loadgen cleanups ahead of the index-addressable
/ query work;
the generated workload is unchanged.

**Config consolidation:**

- Fold `key.size` (`KeyProfile`) into `TransactionProfile.KeySize`;
delete `KeyProfile`.
- Fold `invalid-signatures` and `dependencies` into
`TransactionProfile`; delete
`ConflictProfile`. `DependencyDescription` and the dependency-conflict
machinery
  (`dependenciesModifier`) are unchanged — only their config home moves.
- Inline invalid-signature stamping into the generator and drop
`signTxModifier`; the
per-worker bernoulli decision and dummy endorsement are unchanged. The
generic
  `Modifier` mechanism stays (still used by `dependenciesModifier`).
- Move `key-size`, `invalid-signatures`, and `dependencies` under
`transaction` in the
  config sample and template.

**Batch build/sign pipeline + error-returning construction:**

- Split the per-tx `Next()` into batch methods `buildBatch`/`signBatch`
(with a
`buildAndSignBatch` convenience). The stream worker generates a whole
batch per
iteration (`generateBatches`) instead of wrapping the generator in
`MultiGenerator`;
  the `ingestBatchesToQueue` tx-batching wrapper is removed.
- `newIndependentTxGenerators` and `NewTxStream` now return an error
(surfaced by
`NewLoadGenClient`) instead of `utils.Must`-panicking on tx-builder
setup.

#### Additional details (Optional)

Config consolidation: the generation seed order is preserved (the
inlined
invalid-signature RNG consumes the seed where `signTxModifier` did), so
output is
byte-identical; the coordinator's `BenchmarkDependencyGraph` is
unchanged except for the
moved field reference (`p.Conflicts.Dependencies` ->
`p.Transaction.Dependencies`).

Batch pipeline: the per-worker seeders, key/value generators, the
`Modifier` mechanism
... (continued)

Coverage Stats

47 of 53 new or added lines in 6 files covered. (88.68%)

25 existing lines in 6 files now uncovered.

10336 of 11322 relevant lines covered (91.29%)

33716.64 hits per line