stacklok / toolhive / 30345441341

70%

Build Type

push

github

Committed by web-flow

Commit Message

Recreate the shared external network on a lost teardown race (#6083)

deleteNetworks removes the shared "toolhive-external" Docker network
opportunistically whenever a workload teardown observes zero remaining
toolhive-labeled containers -- a point-in-time check with no
cross-process synchronization. Since concurrent Ginkgo processes (or
any concurrent `thv run` invocations) share one Docker daemon, one
process's teardown can delete the network while another's container
is mid-creation and still needs it, surfacing as "network
toolhive-external not found" from ContainerCreate/ContainerStart.

Observed in CI: a DNS sidecar container failed this way in the "core"
e2e job after it moved to 4 concurrent Ginkgo processes.

Recreate the network and retry once when this specific not-found
condition is hit, and clean up any container Docker leaves behind in
"created" state after a failed start so the retry doesn't collide on
the same name.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

8 of 22 new or added lines in 1 file covered. (36.36%)

73 existing lines in 3 files now uncovered.

81251 of 116527 relevant lines covered (69.73%)

98.43 hits per line