stacklok / toolhive-studio / 30342473918

72%

push

github

fix(deps): upgrade better-sqlite3 to v13 and use bundled prebuilds (#2527)

* fix(deps): upgrade better-sqlite3 to v13 and use bundled prebuilds

Ship N-API prebuilds instead of electron-rebuilding against the CI
runner glibc, fixing better_sqlite3.node requiring GLIBC_2.38 on
Ubuntu 22.04 and Debian 12.

Removes the rebuild postinstall step and copies only better-sqlite3
into packaged apps.

Fixes #2509

Co-authored-by: Cursor <cursoragent@cursor.com>

* test: use path.join for cross-platform forge hook assertions

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: prune better-sqlite3 prebuilds to the build target arch

Copying all bundled prebuilds breaks linux/arm64 RPM builds because
brp-strip cannot process x64 ELF binaries. Keep only the prebuilds
needed for the packaged platform and architecture.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: skip prebuild pruning when platform is unsupported

An empty keep-set would delete every .node file. Guard with an early
return and add tests for the unknown-platform branch.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: dereference pnpm symlinks when copying better-sqlite3

Hoisted pnpm installs can symlink node_modules/better-sqlite3 into the
store; copying without dereference would leave broken paths in the app
package. Update the forge test to assert the copy options.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

5606 of 8299 branches covered (67.55%)

8313 of 11483 relevant lines covered (72.39%)

148.54 hits per line