dunglas / mercure / 30341769748

89%

master: 93%

push

github

fix: don't sort the update's own topic slice while dispatching

encode sorted the slice it was handed, and MatchAny hands it
Update.topics(). Under the deprecated_topic tag that returns the update's
own backing array when only the alternate topics are set, so dispatching
reordered them in place. MarshalJSON, LogValue and SpanAttributes all read
topics() and would then report the new order, persisted history included,
and the sort raced with any concurrent reader of the same update.

Sort the escaped copies instead. The key only has to be one canonical
string per topic set, which that gives just as well.

2 of 2 new or added lines in 1 file covered. (100.0%)

2553 of 2881 relevant lines covered (88.62%)

217.34 hits per line