decentraland / marketplace-server / 30341533777

61%

Build Type

push

github

Committed by web-flow

Commit Message

feat: let the unified catalog feed filter by listing type (#378)

Adds `listingType=primary|secondary` to GET /v3/catalog/unified. Omitted keeps both, so every existing
caller is unaffected.

The Shop needs to stop offering resales. Without a server-side filter its only option is dropping rows
after the fetch, and this feed is paginated and reports a total — so that yields short pages and a count
that overstates what is shown. The filter belongs here.

It reuses the same expression the row mapper already uses for `listingType` (`mv.type =
'public_item_order'` is primary, anything else is a resale), so the filter and the value reported back can
never disagree.

Applies to both the per-listing feed and the grouped item feed (`groupBy=item`) that the browse grid
reads, and — because appendUnifiedFilters runs per UNION branch — to the native and legacy branches
alike. A filter on only one branch would still let legacy resales through, which a caller asking for
`primary` would have no way to notice; the tests assert the constraint lands twice for exactly that
reason.

Invalid values 400 via the existing getValue set-validation rather than falling through as unfiltered,
which is the failure mode that matters: a typo silently returning resales to a client that asked to hide
them.

Coverage Stats

1616 of 3083 branches covered (52.42%)

Branch coverage included in aggregate %.

7 of 0 new or added lines in 0 files covered. (NaN%)

38 existing lines in 2 files now uncovered.

2892 of 4373 relevant lines covered (66.13%)

19.92 hits per line