forst-lang / forst / 30341014938

79%

Build Type

push

github

Committed by haveyaseen

Commit Message

fix(devserver): stop leaked WatchRuntimeDev goroutines in tests

Tests spawned WatchRuntimeDev in the background but never stopped it, since
it only exits on SIGINT/SIGTERM. The leaked goroutines (fsnotify watchers,
signal handlers, reload loops) kept running for the rest of the test binary,
causing stray log output and contended invoke ports to bleed into later
tests and produce flaky failures such as
TestWatchRuntimeDev_fileChange_recompilesAndRestarts missing its restart
deadline. Added a StopCh field to RuntimeRunDeps so WatchRuntimeDev can be
shut down deterministically, and a startWatchRuntimeDev test helper that
stops it via t.Cleanup and waits for exit before the next test runs.

Exercising the shutdown path in tests for the first time surfaced a real
data race: the shared child *runningChild variable was written by the
reload-coalescer goroutine and read by the shutdown goroutine with no
synchronization. Switched it to atomic.Pointer[runningChild].

Also made newTestLogCapture discard the logger's real output so
captured-log tests stop writing to stderr, and widened the recompile test
to poll for startCount reaching 2 instead of asserting immediately after
compileCount, since restarting the child is a separate async step.

Coverage Stats

7 of 11 new or added lines in 1 file covered. (63.64%)

767 existing lines in 16 files now uncovered.

38030 of 50689 relevant lines covered (75.03%)

1075.47 hits per line