valkyrjaio / valkyrja-php / 30328352504
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30328352504

push

github

web-flow 
[CI] Close the remaining reachable branch coverage gaps (#939)

# Description

Follow-up to #936, closing the branch-coverage gaps left open there.
Five more branches now execute,
and the three that remain are shown to be unreachable rather than
untested — so this finishes the
effort.

Each was verified by running the owning shard under `--path-coverage`
before and after:

| File | Before | After |
|------|--------|-------|
| `Orm/Provider/OrmServiceProvider.php` | 14/16 | **16/16** |
| `Mail/Provider/MailServiceProvider.php` | 11/12 | **12/12** |
| `Http/Client/Manager/GuzzleClient.php` | 27/28 | **28/28** |
| `Http/Message/Request/Psr/ServerRequest.php` | 20/21 | **21/21** |

As in #936 these assert real behavior that nothing covered before: that
the optional MySQL strict
mode and storage engine actually reach the DSN, that debug mode turns on
verbose SMTP output, that a
JSON request carrying parsed JSON is not *also* sent with form params,
and that a null parsed body
is normalized to an empty collection rather than cast.

## The last three branches cannot be reached

All three are environment- or invariant-determined, not missing tests:

- **`Http/Message/File/Factory/UploadedFileFactory.php`** —
`! str_starts_with($sapi, 'cli') && ! str_starts_with($sapi, 'phpdbg')`
where `$sapi` is the
`PHP_SAPI` constant. Under PHPUnit `PHP_SAPI` is always `cli`, so the
first operand is false and
the second is never evaluated. `PHP_SAPI` cannot be changed at runtime.
- **`Http/Server/Handler/RequestHandler.php`** —
`defined('PHP_OUTPUT_HANDLER_REMOVABLE') ? … : -1`. The comment above it
explains the fallback is
for HHVM 3.3; on any supported PHP the constant is always defined, so
the `-1` arm is dead.
- **`Cli/Interaction/Message/Answer.php`** — the first clause of
`isValidResponse()`,
`$this->allowedResponses === [] && $validationCallable === null`.
`allowedResponses` can never be
empty: both the constructor and `withAllowedResponses()` append
`$defaultResponse... (continued)

12594 of 12594 relevant lines covered (100.0%)

23.75 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30328352504.1 1138
100.0
 GitHub Action Run
Source Files on build 30328352504