valkyrjaio / project-template-php / 30326805298
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30326805298

push

github

web-flow 
[Template] Rename the Constant class to TemplateInfo (#144)

# Description

`release-new-version.yml` passes
`info-class-path: src/Template/Constant/TemplateInfo.php` to
`_php-create-release.yml`, but no such file exists —
`src/Template/Constant/`
holds `Constant.php`. `_php-update-info-files.yml` would `sed` a path
that is not
there, so the version and build-date constants have never actually been
rewritten
on release. It has gone unnoticed because no release has been cut from
the template
repo.

The class itself was already correct — right constants, right format,
matching the
workflow's `sed` patterns exactly. Only the file and class name were out
of step,
so this is a rename rather than a new file:

- `src/Template/Constant/Constant.php` →
`src/Template/Constant/TemplateInfo.php`
- `final class Constant` → `final class TemplateInfo`

`TemplateInfo` is also the name the rest of the project uses:
`valkyrja-php` has
`src/Valkyrja/Application/Constant/ApplicationInfo.php`, and the
TypeScript,
Python and Go templates all ship a `TemplateInfo` equivalent
(`TemplateInfo.ts`, `template_info.py`, `template/constant/info.go`). A
class named
`Constant` sitting in a `Constant/` directory was the odd one out.

A unit test comes with it, mirroring the Go and Python templates, which
both cover
their info class. `project-template-ts` does not, but the org rule is
100% line and
branch coverage, and the PHPUnit harness plus `TemplateTestCase` base
class were
already in place with no concrete test to use them.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [X] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/Template/Constant/TemplateInfo.php`** — ren... (continued)

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30326805298.1 1
100.0
 GitHub Action Run
Source Files on build 30326805298