valkyrjaio / valkyrja-ts / 30326592312

100%

push

github

[Cli] Split an option arg on the first equals only so values keep theirs (#93)

# Description

Fixes an option value that itself contains an `=` being silently
truncated.

`OptionFactory.fromArg()` took the value with `arg.split('=')[1]` — the
*second*
segment of an unlimited split — so everything from the second `=` onward
was
dropped:

```
--expr=a=b        → value 'a'        (expected 'a=b')
--filter=name=a=b → value 'name'     (expected 'name=a=b')
```

Any option carrying an expression, a query fragment, a base64 value, a
connection string, or a key=value pair lost data, silently and with no
error.
The name was derived separately (`replace(/=[\s\S]*$/, '')`), so it was
already
correct — only the value was wrong.

Now the arg is split on the **first** `=` only: everything before it is
the name,
everything after it is the value, `=` included.

Port of the PHP reference fix

[valkyrja-php#935](https://github.com/valkyrjaio/valkyrja-php/pull/935),
which
uses `explode('=', $arg, 2)` for the same effect. This behavior was
pinned as-is
by the message-mapping fidelity tests
([valkyrja-ts#91](https://github.com/valkyrjaio/valkyrja-ts/pull/91))
and flagged
there as looking like a defect rather than intent — confirmed, and now
fixed in
both ports.

Coverage stays at **100%** (line and branch): 1121 tests, 3509/3509
statements,
1589/1589 branches. Full gate green — `typescript`, `eslint-check`,
`prettier-check`, `vitest-coverage`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`src/Valkyrja/Cli/Interaction/Option/Factory/OptionFactory.ts`** —
split the raw arg on the first `=` only via `indexOf`/... (continued)

1589 of 1589 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

3474 of 3474 relevant lines covered (100.0%)

29.05 hits per line