valkyrjaio / valkyrja-ts / 30325155504

100%

push

github

[Http] Add request, response, and CLI input message-mapping fidelity tests (#91)

# Description

Adds framework-level **message-mapping fidelity** tests: proof that an
incoming
HTTP request, an outgoing HTTP response, and an incoming CLI command map
faithfully onto the framework's own objects — independent of routing.

This implements the architecture TODO item
["Framework tests — request & command mapping
fidelity"](https://github.com/valkyrjaio/architecture/pull/65)
for TypeScript, mirroring the PHP reference implementation

([valkyrja-php#932](https://github.com/valkyrjaio/valkyrja-php/pull/932))
1:1 in
structure and assertions.

A mapping defect — a dropped header, a wrong reason phrase, a mis-parsed
option —
is invisible to route-matching tests. The Java and TypeScript
starter-app
entry/worker end-to-end work surfaced exactly this class of bug, caught
far from
the source. These tests shift that coverage left: sooner, and closer to
where the
mapping actually lives.

The tests are **functional** (they exercise the factory → collection →
message
pipeline as a whole) rather than unit, and assert observable behavior
only,
through the public API. Nothing in `src/` changed — this is a test-only
PR.

## It already caught one

Two assertions in this PR failed against `26.x` as it stood, and were
fixed by its
sibling:

> **valkyrjaio/valkyrja-ts#90 — `[Http] Merge added header values
instead of overriding the existing header`** (merged)

`HeaderCollection::withAddedHeaders()` overrode an existing header
instead of
merging its values, so `Response::withCookie()` could only ever emit one
`Set-Cookie`. That fix is now on `26.x` and this branch is rebased onto
it, so
the suite is green: **1119 tests pass, 100% line and branch coverage**
(3508/3508 statements, 1587/1587 branches), with `typescript`,
`eslint-check`
and `prettier-check` green as well.

Sibling PRs:

- **TypeScript fix** — valkyrjaio/valkyrja-ts#90 (merged)
- **PHP reference** —
[valkyrja-php#932]... (continued)

1587 of 1587 branches covered (100.0%)

Branch coverage included in aggregate %.

3473 of 3473 relevant lines covered (100.0%)

29.01 hits per line