valkyrjaio / sindri-ts / 30325084291

100%

push

github

[Sindri] Resolve binding-key constants declared with as const (#67)

# Description

Sindri generated an empty container cache — `AppContainerData` was
always `super({})` — so a cached (non-debug) application could not
resolve the services the framework itself publishes. In the starter app,
running the CLI with `debug=false` threw
`ContainerInvalidReferenceException: Service with
'Valkyrja.Cli.Server.Handler.InputHandlerContract' not found`, even
though the framework's `CliServerServiceProvider` publishes exactly that
key.

The cause is a single node-kind check.
`AstReader::resolveStaticProperty` tested a static property's
initializer with `isKind(SyntaxKind.StringLiteral)`, but the framework
declares its binding keys as

```ts
static readonly Data = 'Valkyrja.Container.Data.ContainerData' as const;
```

so the initializer is an `AsExpression` wrapping the literal, not the
literal itself. The check failed, the constant resolved to `undefined`,
and `ServiceProviderReader` then dropped every publisher whose key is a
computed `[SomeServiceId.Foo]` — which is how every framework provider
and the application's own `DataServiceProvider` write theirs. With no
publishers surviving, `GenerateDataFromAst::generateContainerData` had
nothing to emit.

Stripping the type-only wrappers an expression may be dressed in — `as`,
`satisfies`, parentheses — reaches the value node underneath, and the
existing string-literal path handles it unchanged. `satisfies` and
parentheses are not used by the framework today, but they are the same
class of purely-typing wrapper and cost nothing to unwrap; leaving them
out would only defer the identical bug.

Verified against the starter app: the CLI cache goes from zero
publishers to 25 (including
`Valkyrja.Cli.Server.Handler.InputHandlerContract`), and the HTTP cache
to 18. The four golden snapshots are unchanged — the golden generators
take publishers as direct input, so nothing about the emitted shape
moved.

This builds on #66, wh... (continued)

836 of 836 branches covered (100.0%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

1333 of 1333 relevant lines covered (100.0%)

12.56 hits per line