valkyrjaio / valkyrja-starter-app-java / 30323608961

100%

push

github

[GitHub] Fix Java source path filters in CI workflow (#47)

# Description

Five of the six Java jobs in `.github/workflows/ci.yml` filter their
source trigger on
`'src/**/*.java'`, but this repository has no root `src/` directory —
all application
source lives under `app/src/main/java/`. `dorny/paths-filter` patterns
are root-anchored,
so `src/**/*.java` matches nothing, ever.

The practical effect is that `spotless`, `archunit`, `errorprone`,
`spotbugs`, and `junit`
never fire for application code changes. They only run when
`.github/ci/<tool>/**` or
`.github/workflows/ci.yml` itself changes. Because the reusable
workflows skip the check
step rather than failing when the filter does not match, the jobs still
report **success** —
so these five required status checks have been passing by never running.

This is not theoretical. #46 changes exactly one file,
`app/src/main/java/app/grpc/Config.java`,
and its Spotless job logged:

```
Filter ci = false
Filter files = false
Changes output set to []
```

and then reported a green check. That same formatting violation had been
latent on `26.x`
since #37 for the same reason, and only surfaced when #45 touched
`ci.yml` — which *is* in the
filter — forcing the job to run against the whole tree.

The `sindri-junit` job already uses the correct `'app/src/**/*.java'`;
this change brings the
other five in line with it. The likely origin of the bug is that
`ci.yml` was adapted from a
repo whose sources genuinely do live at `src/`, and only `sindri-junit`
was corrected.

## Verification

Ran the full gate locally against `26.x` with the corrected filters,
staging the
`*.example.java` stubs the way the tool jobs do (`./gradlew ci
--continue`):

- **ArchUnit** — pass
- **ErrorProne** — pass (2 non-fatal `IncorrectMainMethod` warnings in
`app/cli/App.java`
  and `app/http/CgiApp.java`; reported but not failing)
- **SpotBugs** — pass
- **JUnit + JaCoCo** — pass
- **Spotless** — one tracked-file violation,
`app/src/main/j... (continued)

8 of 8 branches covered (100.0%)

Branch coverage included in aggregate %.

290 of 309 relevant lines covered (93.85%)

5.3 hits per line