valkyrjaio / valkyrja-starter-app-java / 30323320259

100%

push

github

[Grpc] Sort imports in gRPC Config (#46)

# Description

`app/src/main/java/app/grpc/Config.java` has two imports in the wrong
order —
`ResponseSentMiddlewareContract` is listed after
`SendingResponseMiddlewareContract`
instead of alphabetically before it. Google Java Format requires imports
be sorted,
so `spotlessCheck` fails on the file.

The violation was introduced in #37 and has been latent on `26.x` ever
since. It went
unnoticed because the `spotless` job in `.github/workflows/ci.yml`
filters its source
trigger on `'src/**/*.java'`, while this repo's Java source lives under
`app/src/main/java/`. That pattern is root-anchored and matches nothing,
so Spotless
never ran for the change that introduced the violation. It only surfaced
once #45
touched `ci.yml` itself, which is in the job's filter and therefore
forces the job to
run against the whole tree.

This PR fixes only the formatting violation, so #45 can go green. The
underlying path
filter bug — which also affects the `archunit`, `errorprone`,
`spotbugs`, and `junit`
jobs — is fixed separately in a follow-up PR, since switching those
checks on for real
is a larger change.

Verified locally: `./gradlew spotlessCheck --rerun-tasks` fails on
exactly
`app/src/main/java/app/grpc/Config.java` without this change and passes
with it.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`app/src/main/java/app/grpc/Config.java`** — moved
`ResponseSentMiddlewareContract`
above `SendingResponseMiddlewareContract` so the import block is
alphabetically sorted
  and satisfies Google Java Format.

0 of 8 branches covered (0.0%)

Branch coverage included in aggregate %.

114 of 318 relevant lines covered (35.85%)

2.42 hits per line