valkyrjaio / valkyrja-php / 30322719953
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30322719953

push

github

web-flow 
[Http] Add request, response, and CLI input message-mapping fidelity tests (#932)

# Description

Adds framework-level **message-mapping fidelity** tests: proof that an
incoming
HTTP request, an outgoing HTTP response, and an incoming CLI command map
faithfully onto the framework's own objects — independent of routing.

This implements the architecture TODO item
["Framework tests — request & command mapping
fidelity"](https://github.com/valkyrjaio/architecture/pull/65)
for PHP, the reference implementation. Java and TypeScript will mirror
these
tests against the same class/method names.

A mapping defect — a dropped header, a wrong reason phrase, a mis-parsed
option —
is invisible to route-matching tests. The Java and TypeScript
starter-app
entry/worker end-to-end work surfaced exactly this class of bug, caught
far from
the source. These tests shift that coverage left: sooner, and closer to
where the
mapping actually lives.

The tests are **functional** (they exercise the factory → collection →
message
pipeline as a whole, roughly ten units per assertion path) rather than
unit, and
they assert observable behavior only, through the public API. Nothing in
`src/`
changed — this is a test-only PR.

Coverage: line coverage stays at **100%** (9707/9707 lines, 554/554
classes,
2884/2884 methods). Branch coverage rises — `Request::withUri()` and
`MarshalUriFactory::marshalIpv6HostAndPort()` were the two branch gaps
inside the
message-mapping surface, and both are now closed. The repo's overall
branch
figure remains short of 100% because of gaps outside this PR's surface
(`Container`, `Orm`, `Mail`, `Type`, `View`,
`Cli\Interaction\Message\Answer`,
`Cli\Interaction\Output\Output`, and SAPI-dependent guards such as
`UploadedFileFactory::isValidSapiEnvironmentForUploads()`, which no test
can
reach under the CLI SAPI). That shortfall is pre-existing and untouched
here — a
test-only PR cannot lower it, since the phpunit `<source>` block covers
`src`
only.

## What... (continued)

12591 of 12591 relevant lines covered (100.0%)

23.5 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30322719953.1 1138
100.0
 GitHub Action Run
Source Files on build 30322719953