valkyrjaio / sindri-php / 30322611383

100%

push

github

[Http] Expand the any request method when generating routing data (#173)

# Description

A route declared for any request method — `#[Route(..., requestMethods:
[RequestMethod::ANY])]` —
worked when the application ran without cache but could **never be
matched when running from
the generated routing data**.

The framework's `RouteCollection::setRouteToRequestMethods()` expands
`RequestMethod::ANY`
into every concrete method (`RequestMethod::all()`) and deliberately
never stores a literal
`ANY` key, because an incoming request always carries a concrete method.
The generator did
not mirror that: `extractMethodNames()` simply turned
`RequestMethod::ANY` into the string
`"ANY"` and used it as the key for the `paths`, `dynamicPaths`, and
`regexes` maps. A cached
`ANY` route therefore sat under a key that no lookup ever consults, so
the route silently
404'd — while the same application routed it correctly with cache
disabled.

That divergence breaks the rule that the generated cache must mirror
runtime registration
exactly. The fix expands `ANY` in `extractMethodNames()`, which all
three map builders share,
so the generated maps now match `RouteCollection` exactly.

Found while adding one route per routing permutation to the example
application
(valkyrjaio/valkyrja-application), whose `sindri-phpunit` job asserts
the generated routing
table — the `ANY` permutation route was the case that exposed it.

Verified end to end: regenerating the example application with this fix
registers its
`ANY` route under GET, POST, PUT, HEAD, DELETE, CONNECT, OPTIONS, TRACE
and PATCH — identical
to what `RouteCollection` produces at runtime.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existin... (continued)

5 of 5 new or added lines in 1 file covered. (100.0%)

1551 of 1551 relevant lines covered (100.0%)

17.47 hits per line