valkyrjaio / valkyrja-java / 30322506389

100%

push

github

[Cli] Bind options and validate parameters during route dispatch (#53)

# Description

The CLI `Router` only ever bound *arguments*. Its `dispatch` called a
local `bindArguments` helper
and stopped there, so two things the PHP reference does never happened
in Java:

- **Options on the input were ignored.** Nothing ever matched an input
option against a route's
`OptionParameter`, so a command declaring `--force` / `-f` received
nothing no matter what the
user typed. The data classes already had `withOptions` /
`withAddedOptions` and short-name
  support — the router simply never called them.
- **Validation never ran.** `ArgumentParameter.validateValues()` and
`OptionParameter.validateValues()` were fully implemented and fully
tested in isolation, but no
production code path invoked them. `REQUIRED`, `DEFAULT`, `NONE` and
valid-values enforcement
were therefore dead at dispatch: a command declaring a required argument
or option would happily
  dispatch with it missing.

Beyond that, the bound route never reached the container, so a handler
calling
`container.get(RouteContract.class)` could not resolve the command it
was running, and the route's
own middleware was never registered on the four handlers — CLI
route-level middleware silently did
not run. The Java HTTP `Router` already does both correctly; the CLI
port was the outlier.

This ports
`Valkyrja\Cli\Routing\Dispatcher\Router::addParametersToRoute` /
`addArgumentsToRoute` / `addOptionsToRoute` / `routeMatched` faithfully,
so CLI dispatch in Java now
behaves as PHP does.

Two changes are visible in behavior for routes that already worked,
which is why this is a bug fix
rather than an improvement:

- A route declaring a `REQUIRED` argument that the input does not supply
previously dispatched
successfully; it now throws
`CliRoutingArgumentValuesValidationException`, as in PHP.
- An `ARRAY` argument parameter no longer has to be declared last. The
old code gated on
`isLast && ARRAY`; PHP consumes the ... (continued)

1870 of 1872 branches covered (99.89%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 1 file covered. (100.0%)

6836 of 6836 relevant lines covered (100.0%)

4.34 hits per line