kubeovn / kube-ovn / 30317987102

30%

push

github

ovs: skip address set update when the addresses are unchanged (#7084)

AddressSetUpdateAddress overwrote the address set and issued an nb
transaction on every call, without ever comparing the addresses against
the ones already stored. All the call sites sit on reconcile paths
(network policy, anp, cnp, security group, subnet u2o, ippool and vpc
egress gateway), and several of them rewrite address sets whose content
never changes: the network policy except address sets are always given a
nil address list, and the u2o overlay CIDRs address set is named after
the vpc but written once per subnet of that vpc.

The current addresses are read from the local ovsdb cache, so comparing
them costs nothing. Compare them as a set, since the order returned by
strset is not stable, and skip the update when nothing has changed.

While at it, stop formatting the CIDRs in place: the variadic slice is
owned by the caller.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

15 of 16 new or added lines in 1 file covered. (93.75%)

18485 of 61310 relevant lines covered (30.15%)

0.35 hits per line