dangernoodle-io / breadboard / 30316972773

97%

push

github

fix: restore captive-portal redirect via asset-wildcard fallback (HW-confirmed) (#1111)

bb_wifi_prov_start() registered a doomed second GET /* handler
(prov_redirect_handler) after the asset wildcard already claimed that
method+path -- ESP-IDF rejects the duplicate (ESP_ERR_HTTPD_HANDLER_EXISTS,
logged but ignored), so the captive-portal redirect was never live even
though boot logs claimed the portal was up. Confirmed on real hardware: a
phone's captive probe got a 404 instead of the "sign in to network" redirect.

Now registers the redirect as the asset wildcard's no-match fallback via
bb_http_register_assets_with_fallback() -- one /* registration instead of
two. Also checks the return value of every route registration (previously
ignored, which is exactly how this went unnoticed) and propagates failures
out of bb_wifi_prov_start() with an error log; reorders extra() routes ahead
of the wildcard so specific routes still win first-match; corrects the
bb_http_reserve_routes() slot count and comment now that the captive
wildcard no longer consumes its own slot.


Claude-Session: https://claude.ai/code/session_01KM3KoyubaoM6eoUAsw8GYr

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7838 of 8441 branches covered (92.86%)

Branch coverage included in aggregate %.

13330 of 13485 relevant lines covered (98.85%)

2667.53 hits per line