NVIDIA / gpu-operator / 30308146464

35%

main: 35%

push

github

Reject incomplete image specs in ImagePath

When a CR component sets repository or version but leaves repository, image or
version empty, ImagePath/imagePath previously concatenated the parts into a
structurally invalid reference such as "/image:tag", "repo/:tag" or
"repo/image:", which only failed much later at image pull with an opaque
error.

Validate the branch that builds "repo/image:tag"/"@digest" and return a
clear error when repository, image or version is empty, in both
image.ImagePath (internal/image) and the duplicated api/nvidia/v1 imagePath
used by v1.ImagePath. The error uses %s (not %q) so the field values stay
readable in the operator's JSON logs. The kbld/carvel passthrough (repository
and version both empty) and the env-var fallback are unchanged.

Add tests covering the valid tag/digest, kbld passthrough, env fallback,
all-empty error, incomplete-spec and unsupported-type paths.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

6 of 6 new or added lines in 2 files covered. (100.0%)

5066 of 14470 relevant lines covered (35.01%)

0.4 hits per line