decentraland / marketplace / 30303504765

65%

push

github

fix: bound the rental listing status polling (#2667)

waitUntilRentalChangesStatus polled the signatures server on an interval with no exit
condition, so a listing that never reached the expected status kept the tab requesting
forever. it now gives up after MAX_REFRESH_SIGNATURES_RETRIES attempts and throws, which
the sagas calling it already handle through their failure actions.

the non null assertion on openRentalId was also replaced by an explicit guard, so the
caller gets a clear error instead of a request for an undefined listing id.

3682 of 7283 branches covered (50.56%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 1 file covered. (75.0%)

8577 of 11600 relevant lines covered (73.94%)

97.27 hits per line