decentraland / marketplace / 30302890862

65%

master: 65%

Build Type

Pull #2667

github

Committed by LautaroPetaccio

Commit Message

fix: bound the rental listing status polling

waitUntilRentalChangesStatus polled the signatures server on an interval with no exit
condition, so a listing that never reached the expected status kept the tab requesting
forever. it now gives up after MAX_REFRESH_SIGNATURES_RETRIES attempts and throws, which
the sagas calling it already handle through their failure actions.

the non null assertion on openRentalId was also replaced by an explicit guard, so the
caller gets a clear error instead of a request for an undefined listing id.

Pull Request Pull Request #2667: fix: bound the rental listing status polling

Coverage Stats

3678 of 7283 branches covered (50.5%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 1 file covered. (75.0%)

12 existing lines in 5 files now uncovered.

8565 of 11600 relevant lines covered (73.84%)

96.16 hits per line